Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_database - add support for long_term_retention_policy and short_term_retention_policy #8765

Merged
merged 8 commits into from
Oct 7, 2020

Conversation

jackofallops
Copy link
Member

encompasses and supersedes #6194

closes #1802

Ramunas Leknickas and others added 7 commits October 5, 2020 09:53
retentions need to be computed as they have hidden defaults

tweak schema checking on create for retention

Hyperscale omission for LRP

Hyperscale omission for LRP on Read

hyperscale hack for SRP

importstep for udpatetest
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I did have one point to chat about around defaulting values

website/azurerm.erb Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackofallops
Copy link
Member Author

Tests passing (failures unrelated to change / transient)
image

@jackofallops jackofallops merged commit edacf0a into master Oct 7, 2020
@jackofallops jackofallops deleted the sql_backup_policies branch October 7, 2020 16:23
jackofallops added a commit that referenced this pull request Oct 7, 2020
@jackofallops jackofallops added this to the v2.31.0 milestone Oct 7, 2020
@ghost
Copy link

ghost commented Oct 8, 2020

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources and Datasources for SQL Server Backups
4 participants