Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional dedicated host SKU DSv4-Type1 #8681

Closed
briancunningham-ais opened this issue Sep 29, 2020 · 3 comments · Fixed by #8718
Closed

Support for additional dedicated host SKU DSv4-Type1 #8681

briancunningham-ais opened this issue Sep 29, 2020 · 3 comments · Fixed by #8718
Milestone

Comments

@briancunningham-ais
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The newly introduced azurerm_dedicated_host validates the sku_name property for one of DSv3-Type1, DSv3-Type2, ESv3-Type1 ESv3-Type2, FSv2-Type2 valid values. Microsoft Azure introduced additional SKU DSv4-Type1 for their Dedicated Host offering. Request that validation for azurerm_dedicated_host implementation be changed to allow the additional SKU.

New or Affected Resource(s)

Affects existing azurerm_dedicated_host resource, sku_name property.

Potential Terraform Configuration

No changes to existing Terraform configuration. Existing property should support additional valid values.

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

Based on the 1.42 delivered feature, tracked in this pull request

@briancunningham-ais briancunningham-ais changed the title Support for [additional dedicated host SKU DSv4-Type1] Support for additional dedicated host SKU DSv4-Type1 Sep 29, 2020
@nexxai
Copy link
Contributor

nexxai commented Oct 1, 2020

Submitted PR here

@mbfrahry mbfrahry added this to the v2.31.0 milestone Oct 2, 2020
@ghost
Copy link

ghost commented Oct 8, 2020

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants