Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service Plan: support for attaching to an App Service Environment #850

Merged
merged 4 commits into from
Feb 17, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Unfortunately as we don't support creating App Service Environments in Terraform yet (they take 1.5-2 hours to provision) - I can't add a test for this behaviour at the current time..

I've got a branch with some initial scaffolding for App Service Environments, but testing it is kind of painful - but I'd hope that we should be able to add support for this in the near future, when we do - I'll be sure to add some tests for this retroactively

@tombuildsstuff tombuildsstuff added this to the 1.1.2 milestone Feb 16, 2018
@tombuildsstuff tombuildsstuff requested a review from a team February 16, 2018 23:09
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff
Copy link
Contributor Author

Manual confirmation that attaching to a V1 App Service Environment works ✅

@tombuildsstuff tombuildsstuff force-pushed the app-service-plan-env-id branch from da08fcf to 162801b Compare February 17, 2018 00:21
@tombuildsstuff
Copy link
Contributor Author

App Service Plan Resource tests pass:

screen shot 2018-02-16 at 16 29 11

App Service Plan Data Source tests pass:

$ acctests azurerm TestAccDataSourceAzureRMAppServicePlan_
=== RUN   TestAccDataSourceAzureRMAppServicePlan_basic
--- PASS: TestAccDataSourceAzureRMAppServicePlan_basic (89.57s)
=== RUN   TestAccDataSourceAzureRMAppServicePlan_complete
--- PASS: TestAccDataSourceAzureRMAppServicePlan_complete (65.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	155.471s

@tombuildsstuff
Copy link
Contributor Author

Fixes #712

@davidlbyrne
Copy link

I have started to create IaC with terraform and we have been hung up on the Azure ASE integration.

When I don't specify the key for maximum_number_of_workers I get this error:
azurerm_app_service_plan.ilbase-plan:
Status=400 Code="BadRequest" Message="NumberOfWorkers is invalid."

When I add it into the properties block:
azurerm_app_service_plan.ilbase-plan: properties.0: invalid or unknown key: maximum_number_of_workers

Maybe I don't understand how this is supposed to work. Any help would be greatly appreciated.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants