-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Service Plan: support for attaching to an App Service Environment #850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Manual confirmation that attaching to a V1 App Service Environment works ✅ |
da08fcf
to
162801b
Compare
App Service Plan Resource tests pass: App Service Plan Data Source tests pass:
|
Fixes #712 |
I have started to create IaC with terraform and we have been hung up on the Azure ASE integration. When I don't specify the key for maximum_number_of_workers I get this error: When I add it into the properties block: Maybe I don't understand how this is supposed to work. Any help would be greatly appreciated. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Unfortunately as we don't support creating App Service Environments in Terraform yet (they take 1.5-2 hours to provision) - I can't add a test for this behaviour at the current time..
I've got a branch with some initial scaffolding for App Service Environments, but testing it is kind of painful - but I'd hope that we should be able to add support for this in the near future, when we do - I'll be sure to add some tests for this retroactively