azurerm_application_gateway - removing crash points
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
changed the title
azurerm_application_gateway - removing crash pointsazurerm_application_gateway - removing crash points
|
Ignoring the known Azure API deletion bug, which happens a large percentage of the time (which we can't work around 😞):
The tests pass:
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure API returns the latest version of a resource at the last time it was changed, which for an existing resource could be from 2 years ago not conforming to the latest schema; such that some fields which are Required in the API are missing from the API response.
As such - this PR goes through and removes all potential crash points that I could see in the App Gateway resource's flatten functions - which should fix #816 and a few other issues
Unfortunately this is painful to test, since each test takes 30m - so this is a WIP until I can confirm everything works as expected. This is kind of a rework of #632 but without all the additional tests (which we can't add due to an API bug)
Fixes #816