-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_eventhub_consumer_group - allow the name property to be set to $Default #8388
Conversation
@jackofallops would something like this work? Had to split validation for datasource and resource, to make sure people won't mangle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @favoretti
Thanks for this PR, I've had a quick look over and left one comment to look at initially since the new validation method regex would inadvertently allow invalid strings and not match $Default
as intended.
Thanks!
azurerm/internal/services/eventhub/eventhub_consumer_group_data_source.go
Outdated
Show resolved
Hide resolved
…a_source.go Co-authored-by: Steve <[email protected]>
azurerm/internal/services/eventhub/eventhub_consumer_group_data_source.go
Outdated
Show resolved
Hide resolved
@neil-yechenwei @jackofallops Feedback addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @favoretti - LGTM now! 🚀
This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.28.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #7720