Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_linux|windows_virtual_machine and azurerm_linux|windows_virtual_machine_scale_set - Support encryption_at_host_enabled #8322

Merged
merged 18 commits into from
Sep 9, 2020

Conversation

ArcturusZhang
Copy link
Contributor

Supersede #8134

JulienBalestra and others added 14 commits August 26, 2020 12:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Julien Balestra <julien.balestra@datadoghq.com>
Signed-off-by: Julien Balestra <julien.balestra@datadoghq.com>
Signed-off-by: Julien Balestra <julien.balestra@datadoghq.com>
Signed-off-by: Julien Balestra <julien.balestra@datadoghq.com>
@ghost ghost added the size/XXL label Sep 2, 2020
@ArcturusZhang
Copy link
Contributor Author

All tests have passed:

=== RUN   TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabled
=== PAUSE TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabled
=== CONT  TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabled
--- PASS: TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabled (287.18s)
=== RUN   TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabledUpdate
=== PAUSE TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabledUpdate
=== CONT  TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabledUpdate
--- PASS: TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabledUpdate (418.35s)
=== RUN   TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabledWithCMK
=== PAUSE TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabledWithCMK
=== CONT  TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabledWithCMK
--- PASS: TestAccLinuxVirtualMachine_otherEncryptionAtHostEnabledWithCMK (567.91s)
=== RUN   TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHost
=== PAUSE TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHost
=== CONT  TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHost
--- PASS: TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHost (235.12s)
=== RUN   TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHostUpdate
=== PAUSE TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHostUpdate
=== CONT  TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHostUpdate
--- PASS: TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHostUpdate (305.41s)
=== RUN   TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHostWithCMK
=== PAUSE TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHostWithCMK
=== CONT  TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHostWithCMK
--- PASS: TestAccAzureRMLinuxVirtualMachineScaleSet_otherEncryptionAtHostWithCMK (590.23s)
=== RUN   TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabled
=== PAUSE TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabled
=== CONT  TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabled
--- PASS: TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabled (357.87s)
=== RUN   TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabledUpdate
=== PAUSE TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabledUpdate
=== CONT  TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabledUpdate
--- PASS: TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabledUpdate (782.34s)
=== RUN   TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabledWithCMK
=== PAUSE TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabledWithCMK
=== CONT  TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabledWithCMK
--- PASS: TestAccWindowsVirtualMachine_otherEncryptionAtHostEnabledWithCMK (794.18s)
=== RUN   TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabled
=== PAUSE TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabled
=== CONT  TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabled
--- PASS: TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabled (346.02s)
=== RUN   TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabledUpdate
=== PAUSE TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabledUpdate
=== CONT  TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabledUpdate
--- PASS: TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabledUpdate (465.22s)
=== RUN   TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabledWithCMK
=== PAUSE TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabledWithCMK
=== CONT  TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabledWithCMK
--- PASS: TestAccAzureRMWindowsVirtualMachineScaleSet_otherEncryptionAtHostEnabledWithCMK (700.09s)
PASS

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff self-assigned this Sep 4, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests have picked up a bug here - if we can fix that up then this should otherwise be good to merge 👍

string(compute.Manual),
string(compute.Rolling),
string(compute.AutomaticByPlatform),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be:

Suggested change
string(compute.AutomaticByPlatform),
string(compute.UpgradeModeAutomatic),
string(compute.UpgradeModeManual),
string(compute.UpgradeModeRolling),

@ArcturusZhang
Copy link
Contributor Author

Hi @tombuildsstuff I have resolved the last comment, could you please have a look again?

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit 2dc4b9e into hashicorp:master Sep 9, 2020
@ArcturusZhang ArcturusZhang deleted the jb/encry branch September 9, 2020 08:17
WodansSon added a commit that referenced this pull request Sep 9, 2020
@ghost
Copy link

ghost commented Sep 10, 2020

This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.27.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants