Fix reprovisioning of VM when we attach and detach data disk. #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is already reviewed and tested as #778 |
|
Run the tests with test fix and no new failures. @tombuildsstuff Can you please merge this ? |
|
Sapient verified that this Pull Request solves their problem. |
| @@ -227,7 +227,7 @@ func TestAccAzureRMVirtualMachine_bugAzureRM33(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccAzureRMVirtualMachine_changeStorageDataDiskCreationOption(t *testing.T) { | |||
| func TestAccAzureRMVirtualMachine_attachSecondDataDiskWithAttachOption(t *testing.T) { | |||
There was a problem hiding this comment.
This test currently fails:
------- Stdout: -------
=== RUN TestAccAzureRMVirtualMachine_attachSecondDataDiskWithAttachOption
--- FAIL: TestAccAzureRMVirtualMachine_attachSecondDataDiskWithAttachOption (706.71s)
testing.go:459: Step 1 error: Check failed: Check 3/3 error: azurerm_virtual_machine.test: Attribute 'storage_data_disk.0.create_option' expected "Attach", got "Empty"
FAIL
I've pushed a commit to fix this
|
Ignoring an Azure provisioning failure - the tests pass:
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same pull request as Fixes issue when we need to attach/detach data disks #778 . Creating this as I did not wanted to reapply the 42 commits.