azurerm_subnet - add support for Service Endpoints

[lstolyarov]

Hey @tombuildsstuff,

Since Virtual Network Service Endpoints for Storage Accounts are now GA (https://azure.microsoft.com/en-us/blog/virtual-network-service-endpoints-and-firewalls-for-azure-storage-now-generally-available/), I have started a pull request for subnets to support multiple endpoints, in a view that SQL endpoints will be made GA too.

Tests are passing:

$ make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMSubnet_serviceEndpoints'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMSubnet_serviceEndpoints -timeout 180m
=== RUN   TestAccAzureRMSubnet_serviceEndpoints
--- PASS: TestAccAzureRMSubnet_serviceEndpoints (102.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	102.671s

Storage account changes to follow in another PR.

[tombuildsstuff]

hey @lstolyarov

Thanks for this PR - I've taken a look through and this LGTM 👍

Thanks!

[tombuildsstuff]

Tests pass:

[rohrerb]

Is there a separate request for Storage Account Firewall (IP Restrictions)?

I believe this is the Go SDK Model - https://github.com/Azure/azure-sdk-for-go/blob/5bf28521f7a6f72f2dde3e5a5fb0d27d7a8aeee9/services/storage/mgmt/2017-10-01/storage/models.go#L932

[tombuildsstuff]

@rohrerb this is being tracked in #416

[rohrerb]

Thanks Tom.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!