Associate WAF policy to Application Gateway listener (fixes 6485)

[rikribbers]

No description provided.

[rikribbers]

The build is failing on "make depscheck" ; error: gimme: given '1.13.x' but no release for '1.13' found

I don't know why, but does "works on my machine" count as this does not reproduce on my local machine with go 1.13.8

Looking at other build they seem to run on go 1.13 in travis. Could this be a travis hickup or am I missing something.. any feedback is highly appreciated.

[tombuildsstuff]

hey @rikribbers

Thanks for this PR :)

Taking a look through this is looking good - if we can fix up the comments then this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

@rikribbers taking a look through that appears to be an error within Travis, I've re-triggered this :)

[manicminer]

Fixes #6485

[manicminer]

@rikribbers Thanks for the updates, this LGTM!

Test results:

[ghost]

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

[HumanJoubert]

Hi, ran into an issue with the associating the listeners. I was able to only associate one WAF policy to an application gateway. Currently i have multiply WAF polices which needs to be associated to different listeners within the same application gateway. I tried this

Got this error

Error: Attribute redefined

on Main.tf line 79, in resource "azurerm_application_gateway" "tenant":
79: firewall_policy_id = azurerm_web_application_firewall_policy.externalwafpolicyrdweb.id

The argument "firewall_policy_id" was already set at Main.tf:78,3-21. Each
argument may be set only once.

Any way to get this fixed ?

[rikribbers]

Hi @HumanJoubert,

An application gateway can have 1 policy on the application gateway level. When assigning waf policies to specific listeners use the (optional) firewall_policy_id in the http_listener block of the application gateway resource.

See https://www.terraform.io/docs/providers/azurerm/r/application_gateway.html and look for the http_listener block.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!