azurerm_monitor_activity_log_alert: support properties.recommendationType

[magodo]

azurerm_monitor_activity_log_alert: support properties.recommendationType for recommendation alerts.

There is no document for this field, but via inspecting the API flow in portal, the mode is like below:

        "condition": {
            "allOf": [
                {
                    "field": "category",
                    "equals": "Recommendation",
                    "containsAny": null,
                    "odata.type": null
                },
                {
                    "field": "operationName",
                    "equals": "Microsoft.Advisor/recommendations/available/action",
                    "containsAny": null,
                    "odata.type": null
                },
                {
                    "field": "properties.recommendationType",
                    "equals": "2b5eac39-9f50-4d8d-bc9b-1e1e07c5c37e",
                    "containsAny": null,
                    "odata.type": null
                }
            ],
            "odata.type": null
        },

The id can be got from azurerm_advisor_recommendation data source or by other means.

(fix: #7300)

[katbyte]

THanks for the PR @magodo, overall looks good but we have a failing test:

 TestAccAzureRMMonitorActivityLogAlert_basicAndCompleteUpdate: testing.go:640: Step 1 error: errors during apply:
        
        Error: Error creating or updating activity log alert "acctestActivityLogAlert-200624031619256159" (resource group "acctestRG-200624031619256159"): insights.ActivityLogAlertsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="ConditionValueInvalid" Message="Invalid value [email protected] for condition caller"

[magodo]

@katbyte The test also failed in master branch. The cause is that Recommendation category event now has its own fields: properties.RecommendationType, properties.RecommendationCategory and properties.RecommendationImpact.

I complement those into the schema, also fixed the test.

Test Result

💤 via 🦉 v1.14.4 make testacc TEST=./azurerm/internal/services/monitor/tests TESTARGS='-run TestAccAzureRMMonitorActivityLogAlert_'        
                                                                                                                                                                                     
==> Checking that code complies with gofmt requirements...                                                                                                                           
==> Checking that Custom Timeouts are used...                                                                                                                                        
==> Checking that acceptance test packages are used...                                                                                                                               
TF_ACC=1 go test ./azurerm/internal/services/monitor/tests -v -run TestAccAzureRMMonitorActivityLogAlert_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMMonitorActivityLogAlert_basic                                     
=== PAUSE TestAccAzureRMMonitorActivityLogAlert_basic                                     
=== RUN   TestAccAzureRMMonitorActivityLogAlert_requiresImport                                                                                                                       
=== PAUSE TestAccAzureRMMonitorActivityLogAlert_requiresImport                            
=== RUN   TestAccAzureRMMonitorActivityLogAlert_singleResource                                                                                                                       
=== PAUSE TestAccAzureRMMonitorActivityLogAlert_singleResource                      
=== RUN   TestAccAzureRMMonitorActivityLogAlert_complete
=== PAUSE TestAccAzureRMMonitorActivityLogAlert_complete                                                                                                                             
=== RUN   TestAccAzureRMMonitorActivityLogAlert_basicAndCompleteUpdate                                                                                                               
=== PAUSE TestAccAzureRMMonitorActivityLogAlert_basicAndCompleteUpdate                                                                                                               
=== CONT  TestAccAzureRMMonitorActivityLogAlert_basic                                  
=== CONT  TestAccAzureRMMonitorActivityLogAlert_basicAndCompleteUpdate                                                                                                               
=== CONT  TestAccAzureRMMonitorActivityLogAlert_singleResource                                                                                                                       
=== CONT  TestAccAzureRMMonitorActivityLogAlert_complete                                  
=== CONT  TestAccAzureRMMonitorActivityLogAlert_requiresImport                                                                                                                       
--- PASS: TestAccAzureRMMonitorActivityLogAlert_basic (110.98s)                                                                                                                      
--- PASS: TestAccAzureRMMonitorActivityLogAlert_requiresImport (121.56s)                                                                                                             
--- PASS: TestAccAzureRMMonitorActivityLogAlert_basicAndCompleteUpdate (215.16s)                                                                                                     
--- PASS: TestAccAzureRMMonitorActivityLogAlert_singleResource (237.28s)                                                                                                             
--- PASS: TestAccAzureRMMonitorActivityLogAlert_complete (238.26s)                        
PASS                                                                                      
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/monitor/tests       238.295s

[tombuildsstuff]

LGTM - thanks for this @magodo

dismissing since changes have been pushed

[ghost]

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!