Add missing Web Application Firewall Policy settings #7363
Conversation
jackofallops
changed the title
There was a problem hiding this comment.
Hi @boschcrank
Thanks for the PR!
Looks mostly good, just a few comments around the values for the settings being added as well as a few tweaks to tests and docs.
Thanks again!
azurerm/internal/services/network/web_application_firewall_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/web_application_firewall_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/tests/web_application_firewall_policy_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/tests/web_application_firewall_policy_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/tests/application_gateway_resource_test.go
Show resolved
Hide resolved
Co-authored-by: Steve <[email protected]>
Co-authored-by: Steve <[email protected]>
Co-authored-by: Steve <[email protected]>
|
Tests passing: |
|
This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.18.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
fixes #7327