add check for available service provider - azurerm_bot_connection

[njuCZ]

fix #6873

the error message from the service is not user-friendly.

add check for available service provider

[tombuildsstuff]

hey @njuCZ

Thanks for this PR - I've taken a look through and left a couple of comments inline but this is looking good - if we can fix the two comments up then this should otherwise be good to merge 👍

Thanks!

[njuCZ]

@tombuildsstuff thanks for your suggestion, I have modified the PR. Please have a look again

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

@njuCZ running the test for this, this fails:

=== RUN   TestAccAzureRMBotChannelsRegistration
=== RUN   TestAccAzureRMBotChannelsRegistration/connection
=== RUN   TestAccAzureRMBotChannelsRegistration/connection/basic
=== RUN   TestAccAzureRMBotChannelsRegistration/connection/complete
TestAccAzureRMBotChannelsRegistration/connection/complete: testing.go:640: Step 0 error: errors during apply:
Error: the Service Provider "Salesforce" was not found. The available service providers are wunderlist,google,pinterest,appFigures,facebook,SkypeForBusiness,outlook,SharePointOnline,Aadv2,linkedin,trello,SharepointServer,oauth2,slack,zendesk,DynamicsCrmOnline,Aad,smartsheet,flickr,Office365,onedrive,basecamp,instagram,mailchimp,Office365User,echosign,live,oauth2generic,spotify,tumblr,AWeber,marketo,dropbox,box,yammer,intuit,uservoice,salesforce,todoist,github,docusign,stripe,bitly,lithium,sugarcrm

can we update this to be a case-insensitive comparison?

[njuCZ]

Hi @tombuildsstuff sorry for the acctest. I made a change to send ServiceProviderID rather than ServiceProviderDisplayName, because I thought it might be more stable. Please have a look again

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!