azurerm_network_watcher_flow_log destroy fails
#7154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 28, 2020 15:20
tombuildsstuff
suggested changes
Jun 4, 2020
There was a problem hiding this comment.
hi @yupwei68
Thanks for this PR - taking a look through this is looking good, if we can revert the changes to the test function then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/network/tests/network_watcher_flow_log_resource_test.go
Outdated
Show resolved
Hide resolved
added 2 commits
June 9, 2020 10:56
…form-provider-azurerm into wyp-network-watcherFlow
|
@tombuildsstuff @katbyte Thanks for your comments. Please continue reviewing. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6913
=== RUN TestAccAzureRMNetworkWatcherFlowLog_basic
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_basic (160.70s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_disabled
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_disabled (143.00s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_reenabled
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_reenabled (207.17s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_retentionPolicy
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_retentionPolicy (201.46s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_updateStorageAccount
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_updateStorageAccount (228.93s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_trafficAnalytics
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_trafficAnalytics (359.23s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_version
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_version (198.51s)
PASS