-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_iot_time_series_insights_reference_data_set
#7112
Conversation
mbfrahry
commented
May 27, 2020
•
edited
Loading
edited
azurerm_iot_time_series_insights_reference_data_set
azurerm_iot_time_series_insights_reference_data_set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from one minor comment Lgtm!
_, err := client.CreateOrUpdate(ctx, resourceGroup, environmentName, name, dataset) | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qwe could comebine these
_, err := client.CreateOrUpdate(ctx, resourceGroup, environmentName, name, dataset) | |
if err != nil { | |
if _, err := client.CreateOrUpdate(ctx, resourceGroup, environmentName, name, dataset); err != nil { |
), | ||
}, | ||
|
||
"environment_name": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh also would this be more clear as
"environment_name": { | |
"time_series_environment_name": { |
This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.14.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |