Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurern_[linux|windows]_virtual_machine - Correctly check the length of the rsa ssh public_key property #7061

Merged
merged 1 commit into from
May 24, 2020

Conversation

rgl
Copy link
Contributor

@rgl rgl commented May 24, 2020

Fixes #6044

@ghost ghost added the size/XS label May 24, 2020
@katbyte katbyte changed the title Correctly check the length of the rsa ssh public key azurern_[linux|windows]_virtual_machine - Correctly check the length of the rsa ssh public_key property May 24, 2020
@katbyte katbyte added this to the v2.12.0 milestone May 24, 2020
@katbyte katbyte added bug and removed enhancement labels May 24, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @rgl! LGTM 🚀

@katbyte katbyte merged commit 0c8651b into hashicorp:master May 24, 2020
katbyte added a commit that referenced this pull request May 24, 2020
@ghost
Copy link

ghost commented May 28, 2020

This has been released in version 2.12.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.12.0"
}
# ... other configuration ...

pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
@ghost
Copy link

ghost commented Jun 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem to provision ssh keys on resource azurerm_linux_virtual_machine
2 participants