Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignalR features block missing EnableMessagingLogs #7025

Closed
b-twis opened this issue May 20, 2020 · 2 comments · Fixed by #7094
Closed

SignalR features block missing EnableMessagingLogs #7025

b-twis opened this issue May 20, 2020 · 2 comments · Fixed by #7094

Comments

@b-twis
Copy link

b-twis commented May 20, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.12.25

  • provider.azurerm v2.10.0

Affected Resource(s)

  • azurerm_signalr_service

Terraform Configuration Files

resource "azurerm_signalr_service" "signalr" {
  name                = "sandbox-signalr"
  resource_group_name = var.resourcegroup_name
  location            = var.location

  sku {
    name     = "Free_F1"
    capacity = 1
  }

  cors {
    allowed_origins = ["*"]
  }

  features {
    flag  = "ServiceMode"
    value = "Serverless"
  }

  features {
    flag  = "EnableConnectivityLogs"
    value = "False"
  }
}

Debug Output

Panic Output

Expected Behavior

terraform plan should not report any changes directly after a terraform apply

Actual Behavior

Azure seems to set a default value for SignalR feature EnableMessagingLogs.
Currently AzureRM 2.10 does not support this block, causing a modification to show up on every terraform plan.

Currently it takes about 2 mins to perform the modification to remove the default feature block.

Without the feature block

module.function_base.module.signalr.azurerm_signalr_service.signalr will be updated in-place
  ~ resource "azurerm_signalr_service" "signalr" {
        hostname                    = "******.service.signalr.net"
        id                          = "/subscriptions/******/resourceGroups/sandbox-resources/providers/Microsoft.SignalRService/SignalR/sandbox-signalr"
        ip_address                  = "******"
        location                    = "*****"
        name                        = "sandbox-signalr"
        primary_access_key          = (sensitive value)
        primary_connection_string   = (sensitive value)
        public_port                 = 443
        resource_group_name         = "sandbox-resources"
        secondary_access_key        = (sensitive value)
        secondary_connection_string = (sensitive value)
        server_port                 = 443
        tags                        = {}

        cors {
            allowed_origins = [
                "*",
            ]
        }

        features {
            flag  = "ServiceMode"
            value = "Serverless"
        }
        features {
            flag  = "EnableConnectivityLogs"
            value = "False"
        }
      - features {
          - flag  = "EnableMessagingLogs" -> null
          - value = "False" -> null
        }

        sku {
            capacity = 1
            name     = "Free_F1"
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

With the feature block

Error: expected features.2.flag to be one of [EnableConnectivityLogs ServiceMode], got EnableMessagingLogs

  on ..\..\..\..\modules\signalr\main.tf line 1, in resource "azurerm_signalr_service" "signalr":
   1: resource "azurerm_signalr_service" "signalr" {

Steps to Reproduce

  1. terraform apply
  2. terraform plan

Important Factoids

References

@ghost
Copy link

ghost commented Jun 4, 2020

This has been released in version 2.13.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.13.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants