Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VM name and VMSS name validation rule - now names can end with upper case letters #7023

Conversation

ArcturusZhang
Copy link
Contributor

Fixes #6920

@ghost ghost added the size/XS label May 20, 2020
@ArcturusZhang ArcturusZhang added enhancement service/vmss Virtual Machine Scale Sets labels May 20, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

@ArcturusZhang
Copy link
Contributor Author

Hi @tombuildsstuff test cases added, please have a look

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.11.0 milestone May 20, 2020
@tombuildsstuff tombuildsstuff merged commit 336cc52 into hashicorp:master May 20, 2020
tombuildsstuff added a commit that referenced this pull request May 20, 2020
@ArcturusZhang ArcturusZhang deleted the fix-VMSS-name-cannot-end-with-upper-case-letters branch May 21, 2020 06:46
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/vmss Virtual Machine Scale Sets size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The azurerm_windows_virtual_machine resource does not allow names in capitalized finishes.
2 participants