Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added poller to check for consistency on role assignment creation #6925

Merged
merged 2 commits into from
May 14, 2020

Conversation

jackofallops
Copy link
Member

Enhancement to poll separate endpoint to improve eventual consistency checking.
Tests:

 --- PASS: TestAccAzureRMRoleAssignment/basic/emptyName (47.81s)
 --- PASS: TestAccAzureRMRoleAssignment/basic/roleName (46.57s)
 --- PASS: TestAccAzureRMRoleAssignment/basic/dataActions (46.86s)
 --- PASS: TestAccAzureRMRoleAssignment/basic/builtin (45.08s)
 --- PASS: TestAccAzureRMRoleAssignment/basic/custom (49.22s)
 --- FAIL: TestAccAzureRMRoleAssignment/basic/requiresImport (57.47s)
 --- FAIL: TestAccAzureRMRoleAssignment/assignment/group (53.51s)
 --- FAIL: TestAccAzureRMRoleAssignment/management/assign (15.46s)

Failures are expected, and not related to this change.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

@jackofallops jackofallops added this to the v2.10.0 milestone May 14, 2020
@jackofallops jackofallops merged commit 5da16bb into master May 14, 2020
@jackofallops jackofallops deleted the e/role-assignment-consistency branch May 14, 2020 14:12
jackofallops added a commit that referenced this pull request May 14, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants