Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for augmented security rules. #692

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

rrudduck
Copy link
Contributor

@jpthiery
Copy link

Great ! This feature will make more readable our set or Security Rules.
May be Application Security Rule incoming ?

@tombuildsstuff
Copy link
Contributor

I've run the Network Security Group/Rule tests and all the tests pass:

screen shot 2018-01-16 at 12 02 13

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rrudduck

Thanks for this PR - I've taken a look through and this LGTM :)

Thanks!


* `destination_address_prefix` - (Optional) CIDR or destination IP range or * to match any IP. Tags such as ‘VirtualNetwork’, ‘AzureLoadBalancer’ and ‘Internet’ can also be used. This is required if `destination_address_prefixes` is not specified.

* `destination_address_prefixes` - (Optional) List of destination address prefixes. Tags may not be used. This is required if `destination_address_prefix` is not specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may in future want to add some validation for these rules (i.e. that either destination_address_prefix or destination_address_prefixes is set in the Create/Update method) - but this should suffice for now

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: azurerm_network_security_rule add support for , in source_port_range/destination_port_range
3 participants