Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_virtual_machine - export identity attribute #6826

Merged
merged 4 commits into from
May 11, 2020

Conversation

ArcturusZhang
Copy link
Contributor

Fixes #6675

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArcturusZhang, this looks good but we'll need to do a little more work on TestAccDataSourceAzureRMVirtualMachine_basicWindows to get it to pass.

- "address_prefix": [DEPRECATED] Use the `address_prefixes` property instead.
- Reference to undeclared resource: A managed resource "azurerm_linux_virtual_machine" "test" has not been declared in the root module.

@mbfrahry mbfrahry added this to the v2.10.0 milestone May 8, 2020
@ArcturusZhang
Copy link
Contributor Author

Hey @ArcturusZhang, this looks good but we'll need to do a little more work on TestAccDataSourceAzureRMVirtualMachine_basicWindows to get it to pass.

- "address_prefix": [DEPRECATED] Use the `address_prefixes` property instead.
- Reference to undeclared resource: A managed resource "azurerm_linux_virtual_machine" "test" has not been declared in the root module.

Ah, my mistake, I will fix it right away

@ArcturusZhang
Copy link
Contributor Author

Hi @mbfrahry I have resolved the test issues, please have a look again

@ArcturusZhang ArcturusZhang requested a review from mbfrahry May 9, 2020 04:12
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Update data source azurerm_virtual_machine - add identity attribute data.azurerm_virtual_machine - add identity attribute May 11, 2020
@mbfrahry mbfrahry changed the title data.azurerm_virtual_machine - add identity attribute data.azurerm_virtual_machine - export identity attribute May 11, 2020
@mbfrahry mbfrahry merged commit d3bf356 into hashicorp:master May 11, 2020
mbfrahry added a commit that referenced this pull request May 11, 2020
@ArcturusZhang ArcturusZhang deleted the fix-6675 branch May 12, 2020 00:01
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request May 13, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request May 13, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Identity attribute to Virtual Machine Datasource
2 participants