-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource - azurerm_mssql_server #6677
Conversation
1094cc5
to
78fe62a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor fixes. I think the doc changes got mismatched and need another look
@@ -42,6 +42,61 @@ func ExtendedAuditingSchema() *schema.Schema { | |||
} | |||
} | |||
|
|||
func ExpandAzureRmSqlServerBlobAuditingPolicies(input []interface{}) *sql.ExtendedServerBlobAuditingPolicyProperties { | |||
if len(input) == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if len(input) == 0 { | |
if len(input) == 0 || input[0] == nil { |
Just some extra panic protection
|
||
func expandAzureRmSqlServerIdentity(d *schema.ResourceData) *sql.ResourceIdentity { | ||
identities := d.Get("identity").([]interface{}) | ||
if len(identities) == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if len(identities) == 0 { | |
if len(identities) == 0 || identities[0] == nil { |
website/azurerm.erb
Outdated
@@ -1263,10 +1263,18 @@ | |||
<a href="/docs/providers/azurerm/r/sql_server.html">azurerm_sql_server</a> | |||
</li> | |||
|
|||
<li> | |||
<a href="/docs/providers/azurerm/r/mssql_database.html">azurerm_mssql_database</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this was already specified here. Do we want to remove that one as well?
SQL Servers can be imported using the `resource id`, e.g. | ||
|
||
```shell | ||
terraform import azurerm_sql_server.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myresourcegroup/providers/Microsoft.Sql/servers/myserver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
terraform import azurerm_sql_server.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myresourcegroup/providers/Microsoft.Sql/servers/myserver | |
terraform import azurerm_mssql_server.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myresourcegroup/providers/Microsoft.Sql/servers/myserver |
@@ -1,15 +1,15 @@ | |||
--- | |||
subcategory: "Database" | |||
layout: "azurerm" | |||
page_title: "Azure Resource Manager: azurerm_sql_server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes got misplaced. Should this one stay sql_server
?
|
||
--- | ||
|
||
# azurerm_sql_server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be azurerm_mssql_server
?
This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.8.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
version of sql server using the v3.0 rollup composite SDK/api