Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app_service_environment - support for location property #6538

Merged
merged 2 commits into from
Apr 21, 2020
Merged

app_service_environment - support for location property #6538

merged 2 commits into from
Apr 21, 2020

Conversation

neil-yechenwei
Copy link
Contributor

Fix the issue of #6532

@ghost ghost added the size/XS label Apr 20, 2020
tombuildsstuff
tombuildsstuff approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.7.0 milestone Apr 20, 2020
@tracypholmes tracypholmes linked an issue Apr 20, 2020 that may be closed by this pull request
d/app_service_environment: support for location #6532
Closed
katbyte
katbyte requested changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @neil-yechenwei, could we update the docs?

@katbyte katbyte changed the title Add support for location of app service environment app_service_environment - support for location property Apr 21, 2020
@neil-yechenwei
Copy link
Contributor Author

@katbyte , actually doc has already added location property.
See the doc: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/website/docs/d/app_service_environment.html.markdown

@ghost ghost removed the waiting-response label Apr 21, 2020
@neil-yechenwei neil-yechenwei requested a review from katbyte April 21, 2020 04:37
katbyte
katbyte approved these changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! LGTM 👍

@katbyte katbyte merged commit e169230 into hashicorp:master Apr 21, 2020
katbyte added a commit that referenced this pull request Apr 21, 2020
@katbyte
update CHANGELOG.md to include #6538
05d9b17
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
enhancement service/app-service size/XS
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

d/app_service_environment: support for location
3 participants
@neil-yechenwei @tombuildsstuff @katbyte