Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_application_gateway - fix #6452 change frontend_port, redirect_configuration and request_routing_rule to TypeSet #6476

Conversation

ArcturusZhang
Copy link
Contributor

@ArcturusZhang ArcturusZhang commented Apr 15, 2020

Fixes #6452 by changing frontend_port, redirect_configuration and request_routing_rule from TypeList to TypeSet

@ghost ghost added the size/XS label Apr 15, 2020
@katbyte katbyte changed the title Update azurerm_application_gateway - Fix #6452 Update azurerm_application_gateway - make frontend_port a TypeSet (Fix #6452) Apr 15, 2020
@ghost ghost added size/M and removed size/XS labels Apr 15, 2020
@ArcturusZhang
Copy link
Contributor Author

I have changed a lot of other fields by making their Sets since they both also have an attribute of id indicating that their elements should be unique.

@tombuildsstuff tombuildsstuff added this to the v2.7.0 milestone Apr 16, 2020
@ArcturusZhang ArcturusZhang force-pushed the fix-application-gateway-ordering-issue branch from 4324ffa to 4cbfe3b Compare April 22, 2020 04:43
@ArcturusZhang ArcturusZhang force-pushed the fix-application-gateway-ordering-issue branch from 4cbfe3b to 7622f8b Compare April 22, 2020 07:14
@ghost ghost added size/XS and removed size/M labels Apr 22, 2020
@ArcturusZhang ArcturusZhang changed the title Update azurerm_application_gateway - make frontend_port a TypeSet (Fix #6452) Update azurerm_application_gateway - fix #6452 change frontend_port, redirect_configuration and request_routing_rule to TypeSet Apr 22, 2020
@ArcturusZhang
Copy link
Contributor Author

Hi @katbyte I revert the previous too aggressive change (change all of them to TypeSet) to make sure I do not break more things than I fix in this PR 😂

@jackofallops
Copy link
Member

Tests Pass (2 failures unrelated to PR)
image

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops merged commit 0dee2f0 into hashicorp:master Apr 23, 2020
jackofallops added a commit that referenced this pull request Apr 23, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@ArcturusZhang ArcturusZhang deleted the fix-application-gateway-ordering-issue branch April 26, 2020 03:50
@ghost
Copy link

ghost commented May 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_application_gateway: reordering blocks leads to change on every apply.
4 participants