Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of azurerm.kubernetes_cluster.private_link_enabled for enable_private_cluster #6431

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

aristosvo
Copy link
Collaborator

Fixes #6416

Motivation in the issue.

@aristosvo aristosvo force-pushed the privatecluster branch 2 times, most recently from cec571f to cf1970c Compare April 9, 2020 20:42
@aristosvo
Copy link
Collaborator Author

TF_ACC=1 go test -v ./azurerm/internal/services/containers/tests/ -run=AzureRMKubernetesCluster_privateCluster -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceAzureRMKubernetesCluster_privateCluster
--- PASS: TestAccDataSourceAzureRMKubernetesCluster_privateCluster (1302.93s)
=== RUN   TestAccAzureRMKubernetesCluster_privateClusterOn
=== PAUSE TestAccAzureRMKubernetesCluster_privateClusterOn
=== RUN   TestAccAzureRMKubernetesCluster_privateClusterOff
=== PAUSE TestAccAzureRMKubernetesCluster_privateClusterOff
=== CONT  TestAccAzureRMKubernetesCluster_privateClusterOn
=== CONT  TestAccAzureRMKubernetesCluster_privateClusterOff
--- PASS: TestAccAzureRMKubernetesCluster_privateClusterOff (1175.41s)
--- PASS: TestAccAzureRMKubernetesCluster_privateClusterOn (1228.63s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers/tests    2531.589s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests look good 👍

@tombuildsstuff tombuildsstuff merged commit 6b9b6f1 into hashicorp:master Apr 17, 2020
@tombuildsstuff tombuildsstuff added this to the v2.7.0 milestone Apr 17, 2020
tombuildsstuff added a commit that referenced this pull request Apr 17, 2020
@aristosvo aristosvo deleted the privatecluster branch April 17, 2020 14:21
sirlatrom pushed a commit to sirlatrom/terraform-provider-azurerm that referenced this pull request Apr 20, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support private cluster option for AKS clusters
3 participants