Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kubernetes_cluster: making the aci_connector_linux & http_application_routing blocks cloud specific #6370

Merged
merged 4 commits into from
Apr 7, 2020

Conversation

tombuildsstuff
Copy link
Contributor

The blocks aci_connector_linux and http_application_routing are not supported in Azure China or Azure US Government Clouds. As such this commit filters them out if they're disabled (since the API does not allow them to exist in the payload, even if disabled) and returns an error if attempting to use these add-ons in this region.

Fixes #5960
Fixes #5510

…ation_routing` blocks cloud specific

The blocks `aci_connector_linux` and `http_application_routing` are
not supported in Azure China or Azure US Government Clouds. As such
this commit filters them out if they're disabled (since the API does
not allow them to exist in the payload, even if disabled) and returns
an error if attempting to use these add-ons in this region.
@tombuildsstuff tombuildsstuff added this to the v2.5.0 milestone Apr 6, 2020
@tombuildsstuff tombuildsstuff force-pushed the f/aks-conditional-addons branch from babcc62 to bfb0e67 Compare April 6, 2020 14:20
@tombuildsstuff tombuildsstuff requested a review from a team April 6, 2020 14:20
},
azure.USGovernmentCloud.Name: {
httpApplicationRoutingKey, // https://github.com/terraform-providers/terraform-provider-azurerm/issues/5960
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went digging through the Docs & AKS Engine to try and find a definitive list of which add-ons - but ended up with this based on then open issues

@jluk do you know if there's a document stating which add-ons are supported in which cloud environments?

Copy link

@jluk jluk Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not today.

@feiskyer to confirm the 2 missing addons in Azure China/Gov.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Ignoring some known/expected test failures on AKS's end the tests look good:

Screenshot 2020-04-07 at 12 20 05

@tombuildsstuff tombuildsstuff merged commit ba02d9d into master Apr 7, 2020
@tombuildsstuff tombuildsstuff deleted the f/aks-conditional-addons branch April 7, 2020 10:21
tombuildsstuff added a commit that referenced this pull request Apr 7, 2020
@ghost
Copy link

ghost commented Apr 9, 2020

This has been released in version 2.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.5.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants