-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/kubernetes_cluster: making the aci_connector_linux
& http_application_routing
blocks cloud specific
#6370
Conversation
…ation_routing` blocks cloud specific The blocks `aci_connector_linux` and `http_application_routing` are not supported in Azure China or Azure US Government Clouds. As such this commit filters them out if they're disabled (since the API does not allow them to exist in the payload, even if disabled) and returns an error if attempting to use these add-ons in this region.
babcc62
to
bfb0e67
Compare
}, | ||
azure.USGovernmentCloud.Name: { | ||
httpApplicationRoutingKey, // https://github.com/terraform-providers/terraform-provider-azurerm/issues/5960 | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went digging through the Docs & AKS Engine to try and find a definitive list of which add-ons - but ended up with this based on then open issues
@jluk do you know if there's a document stating which add-ons are supported in which cloud environments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not today.
@feiskyer to confirm the 2 missing addons in Azure China/Gov.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there're some list under https://github.com/Azure/AKS/projects/1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 2.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.5.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
The blocks
aci_connector_linux
andhttp_application_routing
are not supported in Azure China or Azure US Government Clouds. As such this commit filters them out if they're disabled (since the API does not allow them to exist in the payload, even if disabled) and returns an error if attempting to use these add-ons in this region.Fixes #5960
Fixes #5510