Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm_public_ip: public_ips can be dynamic for ipv6 addresses #6140

Merged
merged 1 commit into from
Mar 20, 2020
Merged

arm_public_ip: public_ips can be dynamic for ipv6 addresses #6140

merged 1 commit into from
Mar 20, 2020

Conversation

fabianofranz
Copy link
Contributor

@fabianofranz fabianofranz commented Mar 17, 2020 •
edited
Loading

This limitation has been relaxed for standard load balancers.

Fixes #6090.

@ghost ghost added the size/XS label Mar 17, 2020
@fabianofranz fabianofranz mentioned this pull request Mar 17, 2020
Closed
katbyte
katbyte requested changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabianofranz,

Thank you for the pr! I have just one comment inline and thats to invert the test rather then remove it to make sure it does work. thanks!

azurerm/internal/services/network/tests/resource_arm_public_ip_test.go Show resolved Hide resolved
@katbyte katbyte modified the milestones: v2.2.0, v2.3.0 Mar 18, 2020
@ghost ghost added size/S and removed size/XS labels Mar 20, 2020
@fabianofranz
arm_public_ip: public_ips can be dynamic for ipv6 addresses
373a12a 
This limitation has been relaxed for standard load balancers.
@ghost ghost added size/XS and removed size/S labels Mar 20, 2020
@fabianofranz fabianofranz requested a review from katbyte March 20, 2020 20:45
@fabianofranz
Copy link
Contributor Author

Comments addressed.

@ghost ghost removed the waiting-response label Mar 20, 2020
katbyte
katbyte approved these changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @fabianofranz! LGTM 👍

@katbyte katbyte merged commit fd81ba9 into hashicorp:master Mar 20, 2020
katbyte added a commit that referenced this pull request Mar 20, 2020
@katbyte
update CHANGELOG.md toinclude #6140
5ba1b91
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug service/public-ip size/XS
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

Bug: It is not possible to create Static (standard SKU) IPv6 addresses
2 participants
@fabianofranz @katbyte