Fixing the Deadlock issue #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2017
|
Tests pass - probably wants some sanity checking on a couple of resources, but looks good with the configurations posted above: |
tombuildsstuff
changed the title
|
So @radeksimko, @tombuildsstuff and I discussed this on our slack org - we agree that it's not the ideal solution but that, as it's an internal name for the lock, that it won't cause any harm and we can proceed |
tombuildsstuff
pushed a commit
that referenced
this pull request
Jul 4, 2017
Fixing the Deadlock issue
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A deadlock issue was identified in hashicorp/terraform#15204 and hashicorp/terraform#7986.
Investigating further - some Terraform configs have matching Subnet and Virtual Network names - which we lock on due to a requirement in Azure. After discussion with @grubernaut / @mbfrahry I've updated all locks in Azure by Name to prefix the resource name - which isn't ideal but ensures that all locks are unique.
I've used these test cases to validate this - built up from the bugs reported below. The acceptance tests are running at the moment, but this looks like it should be good.
Fixes: