Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kubernetes_cluster: updating the default for load_balancer_sku to Standard #5747

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

tombuildsstuff
Copy link
Contributor

Matches the new default used by the Azure API

Fixes #4465

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 39f48d4 into master Feb 14, 2020
@tombuildsstuff tombuildsstuff deleted the f/aks-standard-lb branch February 14, 2020 13:01
tombuildsstuff added a commit that referenced this pull request Feb 14, 2020
@jluk
Copy link

jluk commented Feb 14, 2020

@tombuildsstuff apologies for getting back to this issue a bit later, the AKS API defaults haven't swapped yet due to some issues found in VMSS. This is still planned but delayed a few months.

Is this work changing the default Terraform will fall back to if left empty? If that is the case this is fine, but just want to be clear on API behaviors today.

@tombuildsstuff
Copy link
Contributor Author

@jluk no worries - if this works planned at some point in the future we have a choice between making this change now or waiting for 3.0 (which is quite a way off - we try and do major versions yearly) - as such is there a downside to defaulting this to Standard early, or should we be flipping this back and waiting for 3.0?

@jluk
Copy link

jluk commented Feb 14, 2020

I think we're good with this change now, thanks Tom.

@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support planned AKS API default swap to VMSS + SLB (from VMAS + BLB)
3 participants