Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: azurerm_private_endpoint expose mapping between group_id and subresource_names #5571

Merged
merged 5 commits into from
Jan 31, 2020

Conversation

WodansSon
Copy link
Collaborator

Some confusion about the naming between terraform and ARM was brought to our attention, adding this code to clarify the mapping.

@WodansSon WodansSon requested a review from katbyte January 31, 2020 02:09
@WodansSon WodansSon added this to the v1.43.0 milestone Jan 31, 2020
@WodansSon WodansSon changed the title Enhancment: azurerm_private_endpoint expose mapping between group_id and subresource_names Enhancement: azurerm_private_endpoint expose mapping between group_id and subresource_names Jan 31, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment LGTM 👍

website/docs/r/private_endpoint.html.markdown Outdated Show resolved Hide resolved
@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit d3883be into master Jan 31, 2020
@WodansSon WodansSon deleted the e_private_link branch January 31, 2020 03:40
WodansSon added a commit that referenced this pull request Jan 31, 2020
@ghost
Copy link

ghost commented Feb 4, 2020

This has been released in version 1.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants