Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_databricks_workspace - allow underscores in name #5548

Merged

Conversation

KimShepherdVibrato
Copy link
Contributor

@KimShepherdVibrato KimShepherdVibrato commented Jan 29, 2020

Underscores are valid characters in an Azure Databricks workspace name.

I've updated the regex and added a couple of test cases to allow undescores to be used in workspace names.

@ghost ghost added the size/XS label Jan 29, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @KimShepherdVibrato, LGTM 👍

@katbyte katbyte added this to the v1.43.0 milestone Jan 30, 2020
@katbyte katbyte changed the title azurerm_databricks_workspace - Fixed the name validation function to allow underscores. azurerm_databricks_workspace - allow underscores in name Jan 30, 2020
@katbyte katbyte merged commit 5a553f7 into hashicorp:master Jan 30, 2020
katbyte added a commit that referenced this pull request Jan 30, 2020
@ghost
Copy link

ghost commented Feb 4, 2020

This has been released in version 1.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants