-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new data source azurerm_mariadb_server
#5506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @tracypholmes, left some mostly minor comments inline
azurerm/internal/services/mariadb/data_source_arm_mariadb_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mariadb/data_source_arm_mariadb_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mariadb/tests/data_source_arm_mariadb_server_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mariadb/tests/data_source_arm_mariadb_server_test.go
Outdated
Show resolved
Hide resolved
azurerm_mariadb_server
azurerm_mariadb_server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes @tracypholmes, just a few more minor comments i've left inline and this should be good to go once they are addressed
azurerm/internal/services/mariadb/data_source_mariadb_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mariadb/data_source_mariadb_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mariadb/data_source_mariadb_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mariadb/data_source_mariadb_server.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes @tracypholmes, this LGTM now 👍
This has been released in version 1.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.43.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #5088.