Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgres - add server name validation #5443

Merged
merged 3 commits into from
Jan 21, 2020
Merged

postgres - add server name validation #5443

merged 3 commits into from
Jan 21, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 20, 2020 •
edited
Loading

@katbyte katbyte added this to the v1.42.0 milestone Jan 20, 2020
@katbyte katbyte requested a review from a team January 20, 2020 01:11
@ghost ghost added the size/L label Jan 20, 2020
jackofallops
jackofallops approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise LGTM

azurerm/internal/services/postgres/resource_arm_postgresql_server.go Outdated Show resolved Hide resolved
@katbyte katbyte merged commit 8e2079b into master Jan 21, 2020
@katbyte katbyte deleted the postgres/casing branch January 21, 2020 02:31
katbyte added a commit that referenced this pull request Jan 21, 2020
@katbyte
Update CHANGELOG.md to include #5443
3ff6433
@ghost
Copy link

ghost commented Jan 27, 2020

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
service/postgresql size/L
Projects
None yet
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.

Error: Provider produced inconsistent final plan in azurerm_postgresql_server
2 participants
@katbyte @jackofallops