Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added functionality to update in place RBAC AAD Profile #5410

Merged
merged 5 commits into from
Jan 24, 2020

Conversation

jackofallops
Copy link
Member

fixes #3779

Note: Needs additional CI Env Vars for ARM_CLIENT_ID_ALT and ARM_CLIENT_SECRET_ALT before merge or update test will fail.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just a couple minor comments outside of what to do about the alt client ID & Secret

@katbyte
Copy link
Collaborator

katbyte commented Jan 17, 2020

Also i think the docs will need to have force new removed?

@ghost ghost added size/L documentation and removed size/M labels Jan 17, 2020
@jackofallops jackofallops requested a review from katbyte January 17, 2020 12:32
@ringods
Copy link

ringods commented Jan 21, 2020

@jackofallops is this the code that will support setting an AD Administrator on an Azure PostgreSQL Server?

https://docs.microsoft.com/en-us/azure/postgresql/howto-configure-sign-in-aad-authentication

@jackofallops
Copy link
Member Author

Hi @ringods - This change is to enable updating the AAD profile for RBAC in an AKS cluster without a rebuild of the cluster.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops merged commit deee4cb into master Jan 24, 2020
@jackofallops jackofallops deleted the f/aks-update-rbac-aad-profile branch January 24, 2020 15:19
jackofallops added a commit that referenced this pull request Jan 24, 2020
@ghost
Copy link

ghost commented Jan 27, 2020

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support update/reset of AKS RBAC AAD profile
3 participants