Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: upgrade azure-sdk-for-go to v38.0.0 & backup to 2019-05-13 #5335

Merged
merged 5 commits into from
Jan 8, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 8, 2020

Supersedes #5236

@katbyte katbyte added this to the v1.41.0 milestone Jan 8, 2020
@katbyte katbyte requested a review from a team January 8, 2020 01:10
@ghost ghost added the size/XXL label Jan 8, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@schlbra schlbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbs up

@katbyte katbyte merged commit d14dc57 into master Jan 8, 2020
@katbyte katbyte deleted the kt/sdk-38 branch January 8, 2020 18:03
@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

katbyte added a commit that referenced this pull request Jan 17, 2020
@ghost
Copy link

ghost commented Feb 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants