Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_api_management_identity_provider_twitter #5306

Merged
merged 1 commit into from
Jan 8, 2020
Merged

New Resource: azurerm_api_management_identity_provider_twitter #5306

merged 1 commit into from
Jan 8, 2020

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Jan 4, 2020

Partially addresses: #5044

Adds the azurerm_api_management_identity_provider_twitter resource.

--- PASS: TestAccAzureRMApiManagementIdentityProviderTwitter_update (1802.14s)
--- PASS: TestAccAzureRMApiManagementIdentityProviderTwitter_basic (1858.36s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/tests 1858.456s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aqche, Thanks for the PR ! aside from one comment i've left inline this is looking good.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dylanegan, this LGTM now 👍

@tombuildsstuff tombuildsstuff merged commit 38a8efe into hashicorp:master Jan 8, 2020
tombuildsstuff added a commit that referenced this pull request Jan 8, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants