Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_redis_firewall_rule #529

Merged
merged 1 commit into from
Nov 6, 2017
Merged

New Resource: azurerm_redis_firewall_rule #529

merged 1 commit into from
Nov 6, 2017

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Nov 6, 2017 •
edited
Loading

This PR adds support for Redis Cache Firewall Rules - as requested in #358

Fixes #358

@tombuildsstuff tombuildsstuff mentioned this pull request Nov 6, 2017
Closed
@tombuildsstuff
Copy link
Contributor Author

Validation Tests:

$ acctests azurerm TestAzureRMRedisFirewallRuleName_validation
=== RUN   TestAzureRMRedisFirewallRuleName_validation
--- PASS: TestAzureRMRedisFirewallRuleName_validation (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	0.019s

mbfrahry
mbfrahry approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff
Copy link
Contributor Author

Acceptance tests pass:

screen shot 2017-11-06 at 16 03 54

@tombuildsstuff tombuildsstuff merged commit 59a8248 into master Nov 6, 2017
@tombuildsstuff tombuildsstuff deleted the redis-firewall-rule branch November 6, 2017 16:04
tombuildsstuff added a commit that referenced this pull request Nov 6, 2017
@tombuildsstuff
Updating to include #529
a3c815f
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement new-resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for managing firewall rules of Azure Redis Cache
2 participants
@tombuildsstuff @mbfrahry