Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/storage_account: making the resource group name case sensitive #5289

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

tombuildsstuff
Copy link
Contributor

Noticed whilst passing through this was case insensitive when it shouldn't be (afaik) - running the tests (with the changes from #5270) the basic test passes:

$ TF_ACC=1 envchain azurerm go test -v ./azurerm/internal/services/storage/tests/ -run=TestAccAzureRMStorageAccount_basic
=== RUN   TestAccAzureRMStorageAccount_basic
=== PAUSE TestAccAzureRMStorageAccount_basic
=== CONT  TestAccAzureRMStorageAccount_basic
--- PASS: TestAccAzureRMStorageAccount_basic (490.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests	490.642s

@tombuildsstuff tombuildsstuff added this to the v1.40.0 milestone Jan 2, 2020
@tombuildsstuff tombuildsstuff requested a review from a team January 2, 2020 15:05
@ghost ghost added the size/XS label Jan 2, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff force-pushed the b/resource-group-insensitivity branch from 45b45c2 to e7ec3fe Compare January 2, 2020 16:59
@tombuildsstuff
Copy link
Contributor Author

Ignoring an unrelated test failure (which'll be fixed in a separate PR) the tests for this look good:

Screenshot 2020-01-06 at 05 22 57

@tombuildsstuff tombuildsstuff merged commit 292abe7 into master Jan 6, 2020
@tombuildsstuff tombuildsstuff deleted the b/resource-group-insensitivity branch January 6, 2020 14:47
tombuildsstuff added a commit that referenced this pull request Jan 6, 2020
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants