Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: azurerm_advanced_threat_protection #4848

Merged
merged 23 commits into from
Dec 18, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Nov 10, 2019

Moves storage ATP into its own resource. Also will work for cosmos fixing #4614

However due to needing to mark the ATP property on the storage account this may be a breaking change and have to wait until the next release is 2.0?

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed I forgot to submit my review from the other day - sorry 🤦‍♂

azurerm/helpers/azure/resourceid.go Outdated Show resolved Hide resolved
azurerm/helpers/azure/resourceid.go Outdated Show resolved Hide resolved
azurerm/resource_arm_advanced_threat_protection.go Outdated Show resolved Hide resolved
azurerm/resource_arm_advanced_threat_protection.go Outdated Show resolved Hide resolved
website/docs/r/advanced_threat_protection.html.markdown Outdated Show resolved Hide resolved
website/docs/r/advanced_threat_protection.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_advanced_threat_protection.go Outdated Show resolved Hide resolved
azurerm/resource_arm_advanced_threat_protection.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff modified the milestones: v2.0.0, v1.38.0, v1.39.0 Nov 28, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.39.0, v1.40.0 Dec 12, 2019
@katbyte katbyte merged commit 2b6e03f into master Dec 18, 2019
@katbyte katbyte deleted the f/resource_adv_threat_protection-new branch December 18, 2019 08:56
katbyte added a commit that referenced this pull request Dec 18, 2019
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants