Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_certificate - support for speciying the subject_alternative_name #479

Closed
jameswhinn opened this issue Oct 31, 2017 · 4 comments · Fixed by #2123
Closed

Comments

@jameswhinn
Copy link

Currently the "azurerm_key_vault_certificate" resource does not allow for the creation of a SubjectAlternativeName within the X509CertificateProperties object. It would be great if the resource could be extended to allow for this.

@kevinneufeld
Copy link

+1 on the above.
It would also be great to have the Thumbprint of the cert as an output.

@tombuildsstuff tombuildsstuff added this to the 1.0.3 milestone Jan 23, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.1.1, 1.1.2 Feb 5, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.1.2, 1.1.3, 1.1.4 Feb 13, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.3.0, Future Mar 2, 2018
@katbyte katbyte added the service/key-vault Key Vault label May 18, 2018
@tombuildsstuff tombuildsstuff changed the title Additions to "azurerm_key_vault_certificate" azurerm_key_vault_certificate - support for speciying the subject_alternative_name May 29, 2018
@draggeta
Copy link
Contributor

draggeta commented Oct 20, 2018

Due to hacktober I decided to try my hand at this. The PR I submitted should fix this.

@kevinneufeld: The thumbprint is already exported from what I can see. It was added in PR #1904

@tombuildsstuff tombuildsstuff modified the milestones: Future, Being Sorted Oct 25, 2018
@katbyte katbyte modified the milestones: Being Sorted, 1.18.0 Oct 25, 2018
@tombuildsstuff
Copy link
Contributor

hi @jameswhinn @kevinneufeld @draggeta

Just to let you know that this has been released as a part of v1.18 of the AzureRM Provider (the full changelog is available here). You can upgrade to this by specifying the version in the provider block (as shown below) and then running terraform init -upgrade

provider "azurerm" {
  version = "=1.18.0"
}

Thanks!

@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants