Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_api - the version and version_set_id properties can now be set #4592

Merged
merged 12 commits into from
Nov 8, 2019

Conversation

kraihn
Copy link
Contributor

@kraihn kraihn commented Oct 10, 2019

Should fix #4297

This is my first Terraform provider pull request and step into programming in Go. What am I missing? Is there anything I need to be aware of in terms of a list of items to check or validate? The footprint of the arguments I'm interested in appears to be small.

@ghost ghost added the size/S label Oct 10, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @kraihn

Thanks for this PR :)

Taking a look through this is off to a good start - if we can add some documentation/tests for this this should otherwise be good to merge 👍

Thanks!

azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
@ghost ghost added size/XS and removed size/S labels Oct 16, 2019
@ghost ghost added documentation size/S and removed size/XS labels Oct 18, 2019
@ghost ghost added size/M and removed size/S labels Oct 18, 2019
@kraihn kraihn changed the title [WIP] Ability to set version and version_set_id for azurerm_api_management_api Ability to set version and version_set_id for azurerm_api_management_api Oct 18, 2019
@kraihn kraihn requested a review from tombuildsstuff October 18, 2019 18:43
@tombuildsstuff tombuildsstuff self-assigned this Oct 29, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @kraihn

Thanks for pushing those changes - apologies for the delayed review here.

This is looking pretty good, I've taken a look through and left some comments inline.

Running the tests for this:

Screenshot 2019-10-30 at 13 06 54

The test TestAccAzureRMApiManagementApi_version fails with:

Error: `version_set_id` is required when `version` is set

Because whilst this field is set in the test, this field is interpolated (and due to a bug in CustomizeDiff, interpolated fields return an empty value, which fails this validation function) - as such if we can remove the CustomizeDiff func then this test should pass

Thanks!

azurerm/resource_arm_api_management_api.go Outdated Show resolved Hide resolved
website/docs/d/api_management_api.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
@sam-cogan
Copy link
Contributor

Would be great to get this added, currently it is impossible to create versioned APIs

@ghost ghost removed the waiting-response label Nov 1, 2019
@kraihn kraihn requested a review from tombuildsstuff November 5, 2019 00:28
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisins @kraihn! LGTM now 👍

@katbyte katbyte added this to the v1.37.0 milestone Nov 8, 2019
@katbyte katbyte changed the title Ability to set version and version_set_id for azurerm_api_management_api azurerm_api_management_api - the version and version_set_id properties can now be set Nov 8, 2019
@katbyte katbyte merged commit 92decd7 into hashicorp:master Nov 8, 2019
katbyte added a commit that referenced this pull request Nov 8, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to associate azurerm_api_management_api to azurerm_api_management_api_version_set
4 participants