Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sql_database - fix #4196 by ensuring read_scale is always set during initial creation #4573

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

hund030
Copy link

@hund030 hund030 commented Oct 9, 2019

The GetOk method always return not ok when the target property is a bool, which cause the read_scale property not works as expected as #4196 explained. Using Get method instead to fix the issue.

@ghost ghost added the size/XS label Oct 9, 2019
@katbyte katbyte added service/mssql Microsoft SQL Server bug labels Oct 10, 2019
@katbyte katbyte added this to the v1.36.0 milestone Oct 10, 2019
@katbyte katbyte changed the title Fix TF issue 4196: Azure SQL Database - read_scale always set to false during initial creation azurerm_sql_database - fix #4196 by ensuring read_scale is always set during initial creation Oct 10, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @hund030, LGTM!

@katbyte katbyte merged commit 77742c5 into hashicorp:master Oct 10, 2019
katbyte added a commit that referenced this pull request Oct 10, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants