Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_role_assignment - changing the skip_service_principal_aad_check property no longer forces a new resource #4412

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

WodansSon
Copy link
Collaborator

(fixes #4393 )

@WodansSon WodansSon added this to the v1.35.0 milestone Sep 23, 2019
@WodansSon WodansSon requested a review from katbyte September 23, 2019 23:55
@WodansSon WodansSon self-assigned this Sep 23, 2019
@katbyte katbyte changed the title Bug: skip_service_principal_aad_check forces recreation azurerm_role_assignment azurerm_role_assignment - changing the skip_service_principal_aad_check no longer forces a new resource Sep 24, 2019
@katbyte katbyte changed the title azurerm_role_assignment - changing the skip_service_principal_aad_check no longer forces a new resource azurerm_role_assignment - changing the skip_service_principal_aad_check property no longer forces a new resource Sep 24, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WodansSon WodansSon merged commit fc9cdfe into master Sep 24, 2019
WodansSon added a commit that referenced this pull request Sep 24, 2019
@WodansSon WodansSon deleted the fix_aad_check branch September 24, 2019 22:48
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of skip_service_principal_aad_check in v1.34.0 forces recreation of azurerm_role_assignment
2 participants