Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_dns_a_record/azurerm_dns_cname_record to export FQDN #4391

Closed
Leon99 opened this issue Sep 20, 2019 · 4 comments · Fixed by #5000
Closed

azurerm_dns_a_record/azurerm_dns_cname_record to export FQDN #4391

Leon99 opened this issue Sep 20, 2019 · 4 comments · Fixed by #5000

Comments

@Leon99
Copy link

Leon99 commented Sep 20, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It would be very convenient if azurerm_dns_a_record and azurerm_dns_cname_record exported the FQDN.

New or Affected Resource(s)

  • azurerm_dns_a_record
  • azurerm_dns_cname_record

Potential Terraform Configuration

resource "azurerm_dns_a_record" "test" {
  name                = "test"
  zone_name           = "${azurerm_dns_zone.test.name}"
  resource_group_name = "${azurerm_resource_group.test.name}"
  ttl                 = 300
  records             = ["10.0.180.17"]
}

resource "azurerm_app_service_custom_hostname_binding" "test" {
  hostname = "${azurerm_dns_a_record.test.fqdn}"
...
...
}
@Leon99 Leon99 changed the title azurerm_dns_a_record to export FQDN azurerm_dns_a_record/azurerm_dns_cname_record to export FQDN Sep 20, 2019
@aqche
Copy link
Contributor

aqche commented Nov 27, 2019

Opened a PR to add fqdn to the two DNS record resources in the issue and went ahead and added the attribute to all the DNS record resources.

@tombuildsstuff tombuildsstuff added this to the v1.38.0 milestone Nov 27, 2019
@ghost
Copy link

ghost commented Dec 7, 2019

This has been released in version 1.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.38.0"
}
# ... other configuration ...

@arkiaconsulting
Copy link

Please note that if you need to use this fqdn attribute with the azurerm_app_service_custom_hostname_binding, you will need to trim the dot at the end of the fqdn.

@ghost
Copy link

ghost commented Dec 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants