Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Application Gateway OWASP 3.1 #4237

Closed
sgissinger opened this issue Sep 4, 2019 · 3 comments · Fixed by #4263
Closed

Allow Application Gateway OWASP 3.1 #4237

sgissinger opened this issue Sep 4, 2019 · 3 comments · Fixed by #4263

Comments

@sgissinger
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Azure Application Gateway now support OWASP version 3.1.

When trying to set this version in Terraform we get this message

expected waf_configuration.0.rule_set_version to be one of [2.2.9 3.0], got 3.1

image

New or Affected Resource(s)

  • azurerm_application_gateway

Potential Terraform Configuration

resource "azurerm_application_gateway" "main" {
  ...
  waf_configuration {
    enabled          = true
    firewall_mode    = "Detection"
    rule_set_type    = "OWASP"
    rule_set_version = "3.1"
  }
}

References

@nexxai
Copy link
Contributor

nexxai commented Sep 5, 2019

Submitted PR #4263

@katbyte katbyte added this to the v1.34.0 milestone Sep 6, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants