Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource & Data Source: azurerm_snapshot #420

Merged
merged 3 commits into from
Oct 12, 2017
Merged

New Resource & Data Source: azurerm_snapshot #420

merged 3 commits into from
Oct 12, 2017

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Oct 12, 2017 •
edited
Loading

  • New Resource: azurerm_snapshot
  • New Data Source: azurerm_snapshot
  • Re-organising all the Compute resources into a Compute section in the sidebar

@tombuildsstuff tombuildsstuff force-pushed the snapshot branch 2 times, most recently from 6aaeaeb to 3c8bd26 Compare October 12, 2017 12:58
@tombuildsstuff
Copy link
Contributor Author

Resource tests pass:

screen shot 2017-10-12 at 14 27 25

@tombuildsstuff tombuildsstuff force-pushed the snapshot branch 3 times, most recently from 5921372 to 1c4beb4 Compare October 12, 2017 14:34
@tombuildsstuff
Copy link
Contributor Author

Snapshot Data Source tests pass:

screen shot 2017-10-12 at 16 04 18

@tombuildsstuff tombuildsstuff changed the title New Resource: azurerm_snapshot New Resource & Data Source: azurerm_snapshot Oct 12, 2017
mbfrahry
mbfrahry approved these changes Oct 12, 2017
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a question

website/docs/r/snapshot.html.markdown

* `create_option` - (Required) Indicates how the snapshot is to be created. Possible values are `Copy` or `Import`. Changing this forces a new resource to be created.

~> **Note:** One of `source_uri`, `source_resource_id` or `storage_account_id` must be specified.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these conflict with each other or can you have all of them specified?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed we'd be able to make these conflicting fields - but apparently you can have them all specified ¯_(ツ)_/¯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird but alright let's ship it!

@tombuildsstuff tombuildsstuff merged commit a8d12b8 into master Oct 12, 2017
@tombuildsstuff tombuildsstuff deleted the snapshot branch October 12, 2017 15:11
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement new-resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @mbfrahry