azurerm_storage_share_directory Allow uppercase characters

[nexxai]

Fixes #4165

[katbyte]

Thanks for this fix @nexxai!

Overall this looks good, however could we add a acc test with uppercase to validate the API accepts uppercase? thanks!

[nexxai]

Overall this looks good, however could we add a acc test with uppercase to validate the API accepts uppercase? thanks!

TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMStorageShareDirectory_uppercase -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMStorageShareDirectory_uppercase
=== PAUSE TestAccAzureRMStorageShareDirectory_uppercase
=== CONT  TestAccAzureRMStorageShareDirectory_uppercase
--- PASS: TestAccAzureRMStorageShareDirectory_uppercase (187.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	190.407s

[tombuildsstuff]

hey @nexxai

Thanks for pushing those changes - this LGTM 👍

dismissing since changes have been pushed

[ghost]

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!