Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azurerm_image] - prevent crash when using data_disk #3797

Merged
merged 2 commits into from
Jul 6, 2019
Merged

Conversation

dedamico
Copy link
Contributor

@dedamico dedamico commented Jul 5, 2019

This fixes Issue #1656 and also prevents crashes for the other data_disk attributes

(fixes #1656)

@ghost ghost added the size/XS label Jul 5, 2019
@dedamico dedamico changed the title fixes Issue 1656 fixes Issue #1656 Jul 5, 2019
@katbyte katbyte changed the title fixes Issue #1656 [azurerm_image] - prevent crash when using data_disk Jul 5, 2019
@katbyte katbyte added this to the v1.32.0 milestone Jul 5, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @dedamico, LGTM 🙂

@katbyte katbyte merged commit d7459a5 into master Jul 6, 2019
@katbyte katbyte deleted the Issue1656 branch July 6, 2019 06:57
katbyte added a commit that referenced this pull request Jul 6, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when using data_disk in azurerm_image
2 participants