-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes crash when no certificate_permissions are defined #374
Fixes crash when no certificate_permissions are defined #374
Conversation
…efined (e.g. when migrating an older config which did not support the certificate_permissions key) Also fixes a bug where the Permissions.Keys was referenced as the source of the Certificates list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @civascu
Thanks for this PR - I've taken a look and this LGTM :)
Tests pass:
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes the terraform crash when no certificate_permissions have been defined (e.g. when migrating an older config which did not support the certificate_permissions key)
Also fixes a bug where the Permissions.Keys was referenced as the source of the Certificates list