-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_app_service & azurerm_app_service_slot: support for specifying user-assigned identities #3637
azurerm_app_service & azurerm_app_service_slot: support for specifying user-assigned identities #3637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joakimhellum-in,
Thanks for the PR, overall this looks good with a few comments left inline. Once those are addressed this should be good to merge!
@katbyte Have made an attempt to address code review comments. Sorry about the mess and for making you review this again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @joakimhellum-in
Thanks for pushing those changes - taking a look through this now LGTM - I'll kick off the tests now 👍
Thanks!
dismissing since changes have been pushed
@joakimhellum-in just noticed there's a conflict - I hope you don't mind but I'm going to rebase this so that we can run the tests / get this merged :) |
Tests pass - thanks for this @joakimhellum-in |
This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.32.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Reference to #3495