Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: azurerm_dev_test_virtual_network #3501

Merged
merged 1 commit into from
May 22, 2019

Conversation

mbfrahry
Copy link
Member

For some reason, subnets only gets modified during update and not create so I've split out the CreateUpdate function into their own create/update functions.

Addressing #2152

--- PASS: TestAccAzureRMDevTestVirtualNetwork_subnet (520.77s)
--- PASS: TestAccAzureRMDevTestVirtualNetwork_basic (520.77s)

@mbfrahry mbfrahry requested a review from a team May 22, 2019 16:41
@ghost ghost added the size/M label May 22, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mbfrahry mbfrahry merged commit 5e29755 into master May 22, 2019
@mbfrahry mbfrahry deleted the b-resource_arm_dev_test_virtual_network_test branch May 22, 2019 22:10
@ghost
Copy link

ghost commented Jun 22, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants